Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling #10649

Merged
merged 2 commits into from
Apr 23, 2023
Merged

Spelling #10649

merged 2 commits into from
Apr 23, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Apr 16, 2023

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/rust-clippy/actions/runs/4710771873#summary-12776860721

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/rust-clippy/actions/runs/4710771874#summary-12776860722

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 16, 2023
jsoref
jsoref commented Apr 16, 2023
View reviewed changes
Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most spelling corrections automatically suggested by Google Sheets (when being run on the rust repository). I've manually transplanted these commits into this repository.

All fault mine.

clippy_lints/src/manual_assert.rs Show resolved Hide resolved
clippy_lints/src/trailing_empty_array.rs Show resolved Hide resolved
clippy_lints/src/types/mod.rs Outdated Show resolved Hide resolved
clippy_lints/src/wildcard_imports.rs Outdated Show resolved Hide resolved
clippy_utils/src/lib.rs Outdated Show resolved Hide resolved
tests/ui/crashes/ice_exact_size.rs Outdated Show resolved Hide resolved
tests/ui/no_mangle_with_rust_abi.rs Outdated Show resolved Hide resolved
tests/ui/option_if_let_else.fixed Show resolved Hide resolved
tests/ui/same_name_method.rs Outdated Show resolved Hide resolved
util/gh-pages/index.html Show resolved Hide resolved
@jsoref jsoref mentioned this pull request Apr 16, 2023
Closed
Jarcho
Jarcho reviewed Apr 17, 2023
View reviewed changes
clippy_lints/src/formatting.rs Show resolved Hide resolved
clippy_lints/src/manual_assert.rs Show resolved Hide resolved
clippy_utils/src/lib.rs Outdated Show resolved Hide resolved
clippy_utils/src/ty.rs Show resolved Hide resolved
tests/ui/needless_for_each_fixable.fixed Outdated Show resolved Hide resolved
tests/ui/needless_for_each_fixable.rs Outdated Show resolved Hide resolved
tests/ui/no_mangle_with_rust_abi.rs Outdated Show resolved Hide resolved
tests/ui/option_if_let_else.fixed Show resolved Hide resolved
tests/ui/same_name_method.rs Outdated Show resolved Hide resolved
clippy_lints/src/wildcard_imports.rs Outdated Show resolved Hide resolved
Jarcho
Jarcho reviewed Apr 17, 2023
View reviewed changes
clippy_utils/src/lib.rs Outdated Show resolved Hide resolved
@jsoref jsoref force-pushed the spelling branch 2 times, most recently from ab9659f to 1d468f2 Compare April 23, 2023 14:52
@jsoref
Copy link
Contributor Author

jsoref commented Apr 23, 2023

Swapped

jsoref added 2 commits April 23, 2023 10:52
@jsoref
Spelling
d2061fa 
* applying
* binding
* complex
* constituent
* demonstrate
* desugaring
* exact
* expression
* for
* functionalities
* github
* implementation
* infers
* multiple conflicting traits
* mutable
* necessarily
* nightly
* nonexistent
* optional
* parameter
* reassignments
* resources
* substitution
* suggestion
* that
* that array is
* using the

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Rewrite search_same description
6f7801f
@Jarcho
Copy link
Contributor

Jarcho commented Apr 23, 2023

Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Apr 23, 2023

📌 Commit 6f7801f has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 23, 2023

⌛ Testing commit 6f7801f with merge 96f8471...

@bors
Copy link
Contributor

bors commented Apr 23, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 96f8471 to master...

@bors bors merged commit 96f8471 into rust-lang:master Apr 23, 2023
@jsoref jsoref deleted the spelling branch April 23, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jules-Bertholet Jules-Bertholet Jules-Bertholet left review comments

@Jarcho Jarcho Jarcho left review comments

Assignees

@Jarcho Jarcho

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsoref @rustbot @Jarcho @bors @Jules-Bertholet