Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lint code from external macros for 8 lints #11009

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jun 23, 2023

Fixes #11008

changelog: [unneeded_field_pattern], [redundant_pattern], [uneeded_wildcard_pattern], [double_neg], [separated_literal_suffix], [unseparated_literal_suffix], [mixed_case_hex_literals], [zero_prefixed_literal]: Don't lint code from external macros

(wow, that's one hell of a changelog for such a small change...)

@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 23, 2023
@Centri3 Centri3 changed the title Don't lint code from external macros for 3 lints Don't lint code from external macros for 8 lints Jun 23, 2023
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@dswij
Copy link
Member

dswij commented Jun 26, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jun 26, 2023

📌 Commit 6cbe35c has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 26, 2023

⌛ Testing commit 6cbe35c with merge 092a09f...

bors added a commit that referenced this pull request Jun 26, 2023
Don't lint code from external macros for 8 lints

Fixes #11008

changelog: [`unneeded_field_pattern`], [`redundant_pattern`], [`uneeded_wildcard_pattern`], [`double_neg`], [`separated_literal_suffix`], [`unseparated_literal_suffix`], [`mixed_case_hex_literals`], [`zero_prefixed_literal`]: Don't lint code from external macros

(wow, that's one hell of a changelog for such a small change...)
@bors
Copy link
Contributor

bors commented Jun 26, 2023

💔 Test failed - checks-action_test

@Centri3 Centri3 force-pushed the unneeded_field_pat branch from 6cbe35c to d295067 Compare June 26, 2023 20:10
@Centri3
Copy link
Member Author

Centri3 commented Jun 26, 2023

@dswij, looks like it needed some minor changes due to ui_test. Can you reapprove? 😅

@dswij
Copy link
Member

dswij commented Jun 27, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jun 27, 2023

📌 Commit d295067 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 27, 2023

⌛ Testing commit d295067 with merge ecdea8c...

@bors
Copy link
Contributor

bors commented Jun 27, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing ecdea8c to master...

@bors bors merged commit ecdea8c into rust-lang:master Jun 27, 2023
@Centri3 Centri3 deleted the unneeded_field_pat branch June 27, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unneeded_field_pattern triggers in macro expansions
4 participants