Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BLESS for compile-test and some cleanup #11039

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

Alexendoo
Copy link
Member

changelog: none

Allows passing the environment variable BLESS to bless tests, which is useful when you want to bless internal tests - BLESS= cargo uitest -Finternal

Also updates a place in the docs referring to cargo dev bless and removes some unused test deps

@rustbot
Copy link
Collaborator

rustbot commented Jun 27, 2023

r? @llogiq

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 27, 2023
@flip1995
Copy link
Member

There are cargo bless and cargo uibless aliases already. Is this additional way to bless tests necessary?

@Alexendoo
Copy link
Member Author

You can't pass feature flags with those, might also be needed for things not using the alias like nextest - #10426 (comment)

@llogiq
Copy link
Contributor

llogiq commented Jun 27, 2023

I don't think such a small benign change needs a huge motivation. Alright!

@bors r+

@bors
Copy link
Contributor

bors commented Jun 27, 2023

📌 Commit 76de556 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 27, 2023

⌛ Testing commit 76de556 with merge 6ce656f...

@bors
Copy link
Contributor

bors commented Jun 27, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 6ce656f to master...

@bors bors merged commit 6ce656f into rust-lang:master Jun 27, 2023
@Alexendoo Alexendoo deleted the bless branch June 27, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants