Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arc_with_non_send_sync: reword and move to suspicious #11104

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

Alexendoo
Copy link
Member

Fixes #11079

changelog: [arc_with_non_send_sync]: move to complexity

@rustbot
Copy link
Collaborator

rustbot commented Jul 4, 2023

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 4, 2023
@Manishearth
Copy link
Member

r? @Centri3

@rustbot
Copy link
Collaborator

rustbot commented Jul 4, 2023

Failed to set assignee to Centri3: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@Alexendoo Alexendoo force-pushed the arc-with-non-send-sync branch from c542081 to db700b0 Compare July 5, 2023 16:27
@Alexendoo Alexendoo changed the title arc_with_non_send_sync: reword and move to complexity arc_with_non_send_sync: reword and move to suspicious Jul 5, 2023
@Alexendoo
Copy link
Member Author

The regex crate updated which is the cause of the test failures, I'll fix that shortly in a separate PR

@Centri3
Copy link
Member

Centri3 commented Jul 5, 2023

I'm happy with this. Thanks! Just need to wait for the other PR to be merged, I suppose

Nice if_chain! -> let chains, btw.

cc @Manishearth

@Manishearth
Copy link
Member

(@Alexendoo feel free to r=Centri3 when ready)

@Alexendoo Alexendoo force-pushed the arc-with-non-send-sync branch from db700b0 to 4939a71 Compare July 7, 2023 12:05
@Alexendoo
Copy link
Member Author

@bors r=Centri3

@bors
Copy link
Contributor

bors commented Jul 7, 2023

📌 Commit 4939a71 has been approved by Centri3

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 7, 2023

⌛ Testing commit 4939a71 with merge 26edd5a...

@bors
Copy link
Contributor

bors commented Jul 7, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Centri3
Pushing 26edd5a to master...

@bors bors merged commit 26edd5a into rust-lang:master Jul 7, 2023
@Alexendoo Alexendoo deleted the arc-with-non-send-sync branch July 7, 2023 12:22
@Alexendoo Alexendoo added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 13, 2023
@flip1995 flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Aug 17, 2023
@flip1995
Copy link
Member

rust-lang/rust#114937

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 17, 2023
…k-Simulacrum

[beta] Clippy backports for ICE fixes

This backports PRs to beta, that fix ICEs, some lint grouping and FP fixes. Namely:

- rust-lang/rust-clippy#11191
- rust-lang/rust-clippy#11172
- rust-lang/rust-clippy#11130
- rust-lang/rust-clippy#11106
- rust-lang/rust-clippy#11104
- rust-lang/rust-clippy#11077
- rust-lang/rust-clippy#11070 (This PR is not synced to the Rust repo yet, but I will open a separate PR to get it into `master`, before beta is branched: rust-lang#114938)
- rust-lang/rust-clippy#11069

Kind of a big backport, but most of it is tests.

r? `@Mark-Simulacrum`

cc `@Manishearth`
@xFrednet xFrednet removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deny-by-default is too strong for arc_with_non_send_sync
7 participants