Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in needless_pass_by_ref_mut lint description #11133

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jul 9, 2023

Someone nicely showed me that I made a small typo in #10900.

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jul 9, 2023

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 9, 2023
@GuillaumeGomez
Copy link
Member Author

r? @llogiq

@rustbot rustbot assigned llogiq and unassigned Manishearth Jul 9, 2023
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 9, 2023

📌 Commit 5363a2b has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 9, 2023

⌛ Testing commit 5363a2b with merge fbba08b...

bors added a commit that referenced this pull request Jul 9, 2023
…arth

Fix typo in `needless_pass_by_ref_mut` lint description

Someone nicely showed me that I made a small typo in #10900.
@bors
Copy link
Contributor

bors commented Jul 9, 2023

💔 Test failed - checks-action_test

@GuillaumeGomez
Copy link
Member Author

Added missing changelog: in commit message.

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 10, 2023

📌 Commit d1575d1 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 10, 2023

⌛ Testing commit d1575d1 with merge 8606a12...

bors added a commit that referenced this pull request Jul 10, 2023
…arth

Fix typo in `needless_pass_by_ref_mut` lint description

Someone nicely showed me that I made a small typo in #10900.
@bors
Copy link
Contributor

bors commented Jul 10, 2023

💔 Test failed - checks-action_test

@Manishearth
Copy link
Member

@bors r+

it needs to be in the PR body, and for a PR like this it can just be none

@bors
Copy link
Contributor

bors commented Jul 10, 2023

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Jul 10, 2023

📌 Commit d1575d1 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 10, 2023

⌛ Testing commit d1575d1 with merge 9ab7137...

@bors
Copy link
Contributor

bors commented Jul 10, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 9ab7137 to master...

@bors bors merged commit 9ab7137 into rust-lang:master Jul 10, 2023
@GuillaumeGomez
Copy link
Member Author

Thanks!

@GuillaumeGomez GuillaumeGomez deleted the fix-description-typo branch July 10, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants