New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests #2 #11225

Merged

bors merged 2 commits into rust-lang:master from matthiaskrgr:fix_integration_tests2

Jul 26, 2023

Member

matthiaskrgr commented Jul 25, 2023 •

edited

Loading

fix integration tests.

It turned out that the following tests fail to build at all:

chalk, combine, stdarch and hyper.

This is often a problem of passing --all-targets --all-features, in case of combine though, outdated deps were to blame.

I have opened tickets against combine and rustfmt
rust-lang/rustfmt#5859
Marwes/combine#357

should we just remove the other failing repos? :/

changelog: fix integration tests on ci

rustbot assigned flip1995

Collaborator

rustbot commented Jul 25, 2023

(rustbot has picked a reviewer for you, use r? to override)

rustbot added the S-waiting-on-review label

Member Author

matthiaskrgr commented Jul 25, 2023

lol

Member Author

matthiaskrgr commented Jul 25, 2023

Contributor

bors commented Jul 25, 2023

⌛ Trying commit 13a067b with merge 81add98...

bors added a commit that referenced this pull request


          Auto merge of #11225 - matthiaskrgr:fix_integration_tests2, r=<try>

81add98

[wip] Fix integration tests2

wip wap wup

Contributor

bors commented Jul 25, 2023

💔 Test failed - checks-action_test

Member Author

matthiaskrgr commented Jul 25, 2023

Contributor

bors commented Jul 25, 2023

⌛ Trying commit 13a067b with merge 16907f9...

bors added a commit that referenced this pull request


          Auto merge of #11225 - matthiaskrgr:fix_integration_tests2, r=<try>

16907f9

[wip] Fix integration tests2

wip wap wup

changelog: lolno

Member Author

matthiaskrgr commented Jul 25, 2023

Contributor

bors commented Jul 25, 2023

⌛ Trying commit 591d277 with merge d39b269...

bors added a commit that referenced this pull request


          Auto merge of #11225 - matthiaskrgr:fix_integration_tests2, r=<try>

d39b269

[wip] Fix integration tests2

wip wap wup

changelog: lolno

matthiaskrgr force-pushed the fix_integration_tests2 branch from 591d277 to 501ae8c Compare

July 25, 2023 15:53

Member Author

matthiaskrgr commented Jul 25, 2023

Contributor

bors commented Jul 25, 2023

⌛ Trying commit 501ae8c with merge 756b075...

bors added a commit that referenced this pull request


          Auto merge of #11225 - matthiaskrgr:fix_integration_tests2, r=<try>

756b075

[wip] Fix integration tests2

wip wap wup

changelog: lolno

Member Author

matthiaskrgr commented Jul 25, 2023

Contributor

bors commented Jul 25, 2023

⌛ Trying commit 3b2e72d with merge 6afa89e...

bors added a commit that referenced this pull request


          Auto merge of #11225 - matthiaskrgr:fix_integration_tests2, r=<try>

6afa89e

[wip] Fix integration tests2

wip wap wup

changelog: lolno

Member Author

matthiaskrgr commented Jul 25, 2023

Contributor

bors commented Jul 25, 2023

⌛ Trying commit 3246de3 with merge 88b81dd...

bors added a commit that referenced this pull request


          Auto merge of #11225 - matthiaskrgr:fix_integration_tests2, r=<try>

88b81dd

[wip] Fix integration tests2

wip wap wup

changelog: lolno

Member Author

matthiaskrgr commented Jul 25, 2023

Contributor

bors commented Jul 25, 2023

⌛ Trying commit 8bd06e7 with merge 70948cf...

bors added a commit that referenced this pull request


          Auto merge of #11225 - matthiaskrgr:fix_integration_tests2, r=<try>

70948cf

[wip] Fix integration tests2

wip wap wup

changelog: lolno

Member Author

matthiaskrgr commented Jul 25, 2023

Contributor

bors commented Jul 25, 2023

⌛ Trying commit 55741f8 with merge afaf22f...

bors added a commit that referenced this pull request


          Auto merge of #11225 - matthiaskrgr:fix_integration_tests2, r=<try>

afaf22f

[wip] Fix integration tests2

wip wap wup

changelog: lolno

Contributor

bors commented Jul 25, 2023

⌛ Trying commit b84fb9b with merge 9c6dd5d...

bors added a commit that referenced this pull request


          Auto merge of #11225 - matthiaskrgr:fix_integration_tests2, r=<try>

9c6dd5d

[wip] Fix integration tests2

wip wap wup

changelog: lolno

matthiaskrgr force-pushed the fix_integration_tests2 branch from b84fb9b to ea5bb6d Compare

July 25, 2023 17:35

Member Author

matthiaskrgr commented Jul 25, 2023

Contributor

bors commented Jul 25, 2023

⌛ Trying commit ea5bb6d with merge 40ec227...

bors added a commit that referenced this pull request


          Auto merge of #11225 - matthiaskrgr:fix_integration_tests2, r=<try>

40ec227

[wip] Fix integration tests2

wip wap wup

changelog: lolno


          ci: integration tests: print clippy run output and set LD_LIBRARY_PAT…

12b63f5

…H to rustc sysroot

matthiaskrgr force-pushed the fix_integration_tests2 branch from ea5bb6d to 12b63f5 Compare

July 25, 2023 17:40

Member Author

matthiaskrgr commented Jul 25, 2023

Contributor

bors commented Jul 25, 2023

⌛ Trying commit 12b63f5 with merge 1e2da92...

bors added a commit that referenced this pull request


          Auto merge of #11225 - matthiaskrgr:fix_integration_tests2, r=<try>

1e2da92

[wip] Fix integration tests2

wip wap wup

changelog: lolno

Contributor

bors commented Jul 25, 2023

☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Build commit: 1e2da92 (1e2da92a4f8e25cc373fdc54c23dd76db56c441b)

matthiaskrgr changed the title ~~[wip] Fix integration tests2~~ [Fix integration tests #2

matthiaskrgr changed the title ~~[Fix integration tests #2~~ Fix integration tests #2

matthiaskrgr marked this pull request as ready for review

July 25, 2023 18:11

Member Author

matthiaskrgr commented Jul 25, 2023

should be ready now ✨

matthiaskrgr mentioned this pull request

test that we correctly detect panics in intergation tests #11228

Merged

bors added a commit that referenced this pull request


          Auto merge of #11228 - matthiaskrgr:fix_integration_tests2__with_test…

7bc5388

…, r=<try>

test that we correctly detect panics in intergation tests

Right now, this should pass as it is on top of #11225

but once I removed that from the pr, I should be able to see the failure.

changelog: add test for integration tests

bors added a commit that referenced this pull request


          Auto merge of #11228 - matthiaskrgr:fix_integration_tests2__with_test…

a412192

…, r=<try>

test that we correctly detect panics in intergation tests

Right now, this should pass as it is on top of #11225

but once I removed that from the pr, I should be able to see the failure.

changelog: add test for integration tests

bors added a commit that referenced this pull request


          Auto merge of #11228 - matthiaskrgr:fix_integration_tests2__with_test…

955f2e2

…, r=<try>

test that we correctly detect panics in intergation tests

Right now, this should pass as it is on top of #11225

but once I removed that from the pr, I should be able to see the failure.

changelog: add test for integration tests

flip1995 reviewed

View reviewed changes

tests/integration.rs

Comment on lines +69 to +70

		// debug:
		eprintln!("{stderr}");

Member

flip1995 Jul 26, 2023

Is this actually a leftover for debugging, or do you want to have this in the tests? From the added --show-output flag, I assume this is left here intentionally.

I think this could be quite useful, just want to make sure it wasn't forgotten about.

Member Author

matthiaskrgr Jul 26, 2023

No, this makes us print the clippy command stderr, but it would still be hidden by the testing harness by default, which is why we also need the other flag.

I think its nice to be verbose by default here so we can see what the problem is right away,in case there are any.

Member

flip1995 Jul 26, 2023

I thought so. Makes sense, let's ship it

Member

flip1995 commented Jul 26, 2023

@bors delegate+

r=me with the comment addressed one way or another.

Thank you for working on this and fixing it! ❤️

Contributor

bors commented Jul 26, 2023

✌️ @matthiaskrgr, you can now approve this pull request!

If @flip1995 told you to "r=me" after making some further change, please make that change, then do @bors r=@flip1995

Member

flip1995 commented Jul 26, 2023

Contributor

bors commented Jul 26, 2023

📌 Commit 12b63f5 has been approved by flip1995

It is now in the queue for this repository.

Contributor

bors commented Jul 26, 2023

⌛ Testing commit 12b63f5 with merge fc13bf8...

Contributor

bors commented Jul 26, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing fc13bf8 to master...

bors merged commit fc13bf8 into rust-lang:master

4 checks passed

bors added a commit that referenced this pull request


          Auto merge of #11228 - matthiaskrgr:fix_integration_tests2__with_test…

13466d0

…, r=<try>

test that we correctly detect panics in intergation tests

should be merged after #11225

changelog: add test for integration tests

bors added a commit that referenced this pull request


          Auto merge of #11228 - matthiaskrgr:fix_integration_tests2__with_test…

d446378

…, r=flip1995

test that we correctly detect panics in intergation tests

should be merged after #11225

changelog: add test for integration tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review