[redundant_guards]: don't lint on float literals
#11305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Centri3
approved these changes
Aug 8, 2023
Centri3
reviewed
Aug 8, 2023
| _ => todo!(), | ||
| } | ||
| match FloatWrapper(0.1) { | ||
| x if x == FloatWrapper(0.0) => todo!(), |
There was a problem hiding this comment.
We'd ideally suggest FloatWrapper(f) if f == 0.0 here, but that can be done in the future.
|
Will approve once CI finishes |
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Merged
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 17, 2024
#13698) Two changes to `redundant_guards`: - Lint float literals. We used to do that before but that was changed in #11305 because at the time there was a future compat warning and it was planned to make pattern matching floats a hard error. In rust-lang/rust#116284 it was decided to actually remove the lint and only make matching `NAN` specifically a hard error. The `NAN` part isn't relevant/important here because this PR only changes what literals are warned and `f64::NAN` isn't a literal, but I've added a test anyway to make sure we continue to not lint there. - Don't lint CStr literals because that can't be a pattern right now (fixes #13681) changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11304
changelog: [
redundant_guards]: don't lint on float literalsr? @Centri3 i figured you are probably a good reviewer for this since you implemented the lint ^^