Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mut_mut]: Fix duplicate diags #12442

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

cookie-s
Copy link
Contributor

@cookie-s cookie-s commented Mar 9, 2024

Relates to #12379

The mut_mut lint produced two diagnostics for each mut mut pattern in ty inside blocks because MutVisitor::visit_ty was called from MutMut::check_ty and MutMut::check_block independently. This PR fixes the issue.


changelog: [mut_mut]: Fix duplicate diagnostics

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 9, 2024
@y21
Copy link
Member

y21 commented Mar 9, 2024

Looks good, thanks!

For something like &mut &mut &mut i32 I believe this lint also emits two warnings when it could just be one, but that's another issue unrelated to this one.

@bors r+

@bors
Copy link
Contributor

bors commented Mar 9, 2024

📌 Commit 4e95b4a has been approved by y21

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 9, 2024

⌛ Testing commit 4e95b4a with merge b2f9c4c...

@bors
Copy link
Contributor

bors commented Mar 9, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing b2f9c4c to master...

@bors bors merged commit b2f9c4c into rust-lang:master Mar 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants