-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[single_match
]: Fix duplicate diagnostics
#12448
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dswij (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
614d364
to
8264f74
Compare
☔ The latest upstream changes (presumably #12440) made this pull request unmergeable. Please resolve the merge conflicts. |
8264f74
to
8e55bbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those two test file point to the same lint
FYI, there are two lints defined in single_match.
let lint = if els.is_some() { SINGLE_MATCH_ELSE } else { SINGLE_MATCH }; |
Thank you! @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Relates to #12379
edit two test file
tests/ui/single_match_else.rs
tests/ui/single_match.rs
those two test file point to the same lint
changelog: [
single_match
] Fix duplicate diagnostics