Rustup to *rustc 1.14.0-nightly (144af3e97 2016-10-02)* and bump to 0.0.93 #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcarton
commented
Sep 30, 2016
| use rustc_const_eval::EvalHint::ExprTypeChecked; | ||
| use rustc_const_eval::eval_const_expr_partial; | ||
| use rustc_const_math::ConstInt; | ||
| use rustc::hir::*; | ||
| use rustc::hir; |
There was a problem hiding this comment.
@Manishearth, @llogiq, @oli-obk
use rustc::hir;, use syntax::ast; and use rustc::ty; make updates like this much easier (ie. sed-able) than use rustc::hir::* or use rustc::ty::TyArray; and I tend to find them clearer. (here there now happens to be something named TyArray in both ty and hir).
Could we decide to prefer that style in the future?
There was a problem hiding this comment.
I like non-glob imports better, too, but I can't promise that I won't accidentally add some, we should create a lint for that (#1228)
Merged
mcarton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#36760 for the first commit. It's already been merged so this might need to be published sooner.→ #1248See rust-lang/rust#36857 for the second commit.