Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[many_single_char_names]: Deduplicate diagnostics #12859

Merged
merged 1 commit into from
May 28, 2024

Conversation

cookie-s
Copy link
Contributor

@cookie-s cookie-s commented May 27, 2024

Relates to #12379

Fix many_single_char_names lint so that it doesn't emit diagnostics when the current level of the scope doesn't contain any single character name.

let (a, b, c, d): (i32, i32, i32, i32);
match 1 {
  1 => (),
  e => {},
}

produced the exact same MANY_SINGLE_CHAR_NAMES diagnostic at each of the Arm e => {} and the Block {}.


changelog: [many_single_char_names]: Fix duplicate diagnostics

@rustbot
Copy link
Collaborator

rustbot commented May 27, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 27, 2024
@cookie-s cookie-s force-pushed the dedup-single-char-name-diag branch from 50d980e to 7110f47 Compare May 27, 2024 02:57
@cookie-s cookie-s marked this pull request as ready for review May 27, 2024 03:02
@Alexendoo
Copy link
Member

Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented May 28, 2024

📌 Commit 7110f47 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 28, 2024

⌛ Testing commit 7110f47 with merge da4b212...

@bors
Copy link
Contributor

bors commented May 28, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing da4b212 to master...

@bors bors merged commit da4b212 into rust-lang:master May 28, 2024
5 checks passed
@cookie-s cookie-s deleted the dedup-single-char-name-diag branch June 2, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants