-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc changes to clippy_config
#13173
Conversation
$(#[lints($($for_lints:ident),* $(,)?)])? | ||
$name:ident: $ty:ty = $default:expr, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so nice! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to the macro look more than good to me. I really like the changes to declare the lints via attributes.
I'm not quite sure about the cargo dev fmt
changes. It's cool, that it actually formats the whole thing and not just errors like rustc's tidy
does. The downside is, that it feels like the custom format adds a lot of complexity. Future changes to the Conf!
macro will likely also require some adaption of the formatting code.
I can't make up my mind about this rn. If you think that this is better than reusing tidy
or rolling a simpler error on non alphabet check, I'd trust you.
Okay, I'm gonna R+ this now. Usually, I wouldn't have mentioned the roses are Red, |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
@rust-lang/clippy Small FYI: This PR changed the syntax of the The configs now roughly look like this: /// Which crates to allow absolute paths from
#[lints(absolute_paths)]
absolute_paths_allowed_crates: FxHashSet<String> = FxHashSet::default(), I like this change. Thank you to @Jarcho for this change :D |
Contains part of #13084
Changes include:
dev fmt
sort the config list.r? @xFrednet
changelog: none