Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to focus on search input using keyboard #13178

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

GuillaumeGomez
Copy link
Member

This PR adds the possibility to focus on the search input with S or / like in rustdoc and mdbook and docs.rs (unification++). Pressing escape will blur it.

r? @Alexendoo

changelog: Add possibility to focus on search input using keyboard

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 29, 2024
util/gh-pages/script.js Outdated Show resolved Hide resolved
util/gh-pages/script.js Outdated Show resolved Hide resolved
@GuillaumeGomez GuillaumeGomez force-pushed the clippy-lints-page-improvement branch from 11a7ec1 to 56d62cf Compare July 29, 2024 18:49
@GuillaumeGomez
Copy link
Member Author

Updated!

util/gh-pages/script.js Outdated Show resolved Hide resolved
@GuillaumeGomez GuillaumeGomez force-pushed the clippy-lints-page-improvement branch from 56d62cf to 6317479 Compare July 29, 2024 19:55
@Alexendoo
Copy link
Member

Thanks! This will be a nice QoL bump

@bors r+

@bors
Copy link
Contributor

bors commented Jul 29, 2024

📌 Commit 6317479 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 29, 2024

⌛ Testing commit 6317479 with merge accf686...

@bors
Copy link
Contributor

bors commented Jul 29, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing accf686 to master...

@bors bors merged commit accf686 into rust-lang:master Jul 29, 2024
4 checks passed
@bors bors mentioned this pull request Jul 29, 2024
@GuillaumeGomez GuillaumeGomez deleted the clippy-lints-page-improvement branch July 30, 2024 08:31
bors added a commit that referenced this pull request Aug 11, 2024
Add settings menu on clippy lints page

It looks like this (when the menu is expanded):

![Screenshot from 2024-08-06 21-36-41](https://github.com/user-attachments/assets/c464aef3-b21e-48cc-8e3a-c32a134f995e)

Follow-up of #13178.

Someone pointed out that they should be able to disable the shortcuts on this page like it's the case for rustdoc and docs.rs. So here we go.

The first commit moves the style into its own file: it's much better for a web browser because it can then cache it.

The second one actually adds the new settings menu you can see above.

r? `@Alexendoo`

changelog: Add settings menu on clippy lints page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants