-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to focus on search input using keyboard #13178
Merged
bors
merged 1 commit into
rust-lang:master
from
GuillaumeGomez:clippy-lints-page-improvement
Jul 29, 2024
Merged
Add possibility to focus on search input using keyboard #13178
bors
merged 1 commit into
rust-lang:master
from
GuillaumeGomez:clippy-lints-page-improvement
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
label
Jul 29, 2024
Alexendoo
reviewed
Jul 29, 2024
Alexendoo
reviewed
Jul 29, 2024
GuillaumeGomez
force-pushed
the
clippy-lints-page-improvement
branch
from
July 29, 2024 18:49
11a7ec1
to
56d62cf
Compare
Updated! |
Alexendoo
reviewed
Jul 29, 2024
GuillaumeGomez
force-pushed
the
clippy-lints-page-improvement
branch
from
July 29, 2024 19:55
56d62cf
to
6317479
Compare
Alexendoo
approved these changes
Jul 29, 2024
Thanks! This will be a nice QoL bump @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
that referenced
this pull request
Aug 11, 2024
Add settings menu on clippy lints page It looks like this (when the menu is expanded): ![Screenshot from 2024-08-06 21-36-41](https://github.com/user-attachments/assets/c464aef3-b21e-48cc-8e3a-c32a134f995e) Follow-up of #13178. Someone pointed out that they should be able to disable the shortcuts on this page like it's the case for rustdoc and docs.rs. So here we go. The first commit moves the style into its own file: it's much better for a web browser because it can then cache it. The second one actually adds the new settings menu you can see above. r? `@Alexendoo` changelog: Add settings menu on clippy lints page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to focus on the search input with
S
or/
like in rustdoc andmdbook
anddocs.rs
(unification++). Pressing escape will blur it.r? @Alexendoo
changelog: Add possibility to focus on search input using keyboard