Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature=cargo-clippy argument #13246

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

xFrednet
Copy link
Member

@xFrednet xFrednet commented Aug 9, 2024

Roses are red,
Violets are blue,
Fixme was written,
And now it's due


changelog: Important Change Removed the implicit cargo-clippy feature set by Clippy as announced here: https://blog.rust-lang.org/2024/02/28/Clippy-deprecating-feature-cargo-clippy.html
#13246

Follow-up of: #12292

r? @flip1995

cc: @GuillaumeGomez

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 9, 2024
@GuillaumeGomez
Copy link
Member

Saw it but didn't send the PR yet. Thanks for doing it! 👍

@xFrednet
Copy link
Member Author

xFrednet commented Aug 9, 2024

No problem at all. =^.^=

I'm stuck on some lintcheck stuff and stumbled across this. I decided to fix this and play the ostrich algorithm on the lintcheck thingy for one more day :D

@GuillaumeGomez
Copy link
Member

Same for me. Still going through #11421. ^^'

@xFrednet
Copy link
Member Author

xFrednet commented Aug 9, 2024

@GuillaumeGomez could oli-obk/ui_test#202 potentially help you?

I don't know the problem, but I wanted to mention that PR just in case.

@GuillaumeGomez
Copy link
Member

I've been using oli's help quite a few time to fix some issues I had with ui-test. The biggest issue now is writing the script to automatically migrate all ui tests to the next syntax.

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, totally forgot about that. I think it's been long enough of a transition phase, so that we can remove it now. But @rust-lang/clippy , if someone thinks we should wait longer, speak now or forever hold your peace.

Let's merge this at the end of the week, if there are no objections.

@xFrednet xFrednet added S-final-comment-period Status: final comment period it will be merged unless new objections are raised (~1 week) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 12, 2024
@xFrednet xFrednet removed the S-final-comment-period Status: final comment period it will be merged unless new objections are raised (~1 week) label Aug 29, 2024
@xFrednet
Copy link
Member Author

This should be ready now. @bors r+

@bors
Copy link
Collaborator

bors commented Aug 29, 2024

📌 Commit 2645ea3 has been approved by xFrednet

It is now in the queue for this repository.

@xFrednet
Copy link
Member Author

@bors r-

@xFrednet
Copy link
Member Author

@bors r=flip1995

@bors
Copy link
Collaborator

bors commented Aug 29, 2024

📌 Commit 2645ea3 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 29, 2024

⌛ Testing commit 2645ea3 with merge b86a202...

@bors
Copy link
Collaborator

bors commented Aug 29, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing b86a202 to master...

@bors bors merged commit b86a202 into rust-lang:master Aug 29, 2024
8 checks passed
@xFrednet xFrednet deleted the 12292-remove-cargo-clippy-feature branch August 29, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants