Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement lint for regex::Regex compilation inside a loop #13412

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Implement lint for regex::Regex compilation inside a loop #13412

merged 2 commits into from
Oct 5, 2024

Conversation

GnomedDev
Copy link
Contributor

@GnomedDev GnomedDev commented Sep 18, 2024 •
edited
Loading

Closes #598.

Seems like a pretty simple one, I'm not sure if I sorted out all the lint plumbing correctly because I was adding it to the existing regex pass, but seems to work. The name is a bit jank and I'm super open to suggestions for changing it.

changelog: [regex_creation_in_loops]: Added lint for Regex compilation inside loops.

@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @y21 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 18, 2024
@GnomedDev GnomedDev force-pushed the regex-comp-in-loop branch 3 times, most recently from 63c6dac to 711fd7f Compare September 20, 2024 13:16
y21
y21 reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started reviewing this 2 days ago but then forgot to continue 😅 Overall looks great aside from a few things

clippy_lints/src/regex.rs Outdated Show resolved Hide resolved
clippy_lints/src/regex.rs Outdated Show resolved Hide resolved
clippy_lints/src/regex.rs Outdated Show resolved Hide resolved
clippy_lints/src/regex.rs Show resolved Hide resolved
@y21
Copy link
Member

y21 commented Sep 20, 2024 •
edited
Loading

Given regex's own advice it makes me wonder if we could just have a lint for regex creations with literals outside of a static anywhere as having it in a static with LazyLock would avoid recompiling it ever again even across function calls, but I can see how that's more... controversial than just this specific pattern

@GnomedDev
Copy link
Contributor Author

Yeah, that would be a separate (pedantic) lint should probably have an issue opened for it, but definitely not this one.

@GnomedDev GnomedDev requested a review from y21 September 21, 2024 12:15
@y21
Copy link
Member

y21 commented Sep 23, 2024

FCP thread for the lint: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/FCP.3A.20regex_creation_in_loops

@y21 y21 added S-final-comment-period Status: final comment period it will be merged unless new objections are raised (~1 week) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Sep 23, 2024
y21
y21 reviewed Oct 5, 2024
View reviewed changes
tests/ui/regex.rs Show resolved Hide resolved
@y21
Copy link
Member

y21 commented Oct 5, 2024

Looks all good now, thank you for working on this lint!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 5, 2024

📌 Commit 196dbcf has been approved by y21

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 5, 2024

⌛ Testing commit 196dbcf with merge 753629b...

@bors
Copy link
Contributor

bors commented Oct 5, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing 753629b to master...

@bors bors merged commit 753629b into rust-lang:master Oct 5, 2024
9 of 11 checks passed
@GnomedDev GnomedDev deleted the regex-comp-in-loop branch October 5, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y21 y21 y21 approved these changes

Assignees

@y21 y21

Labels
S-final-comment-period Status: final comment period it will be merged unless new objections are raised (~1 week)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn when compiling regexes in a loop
4 participants
@GnomedDev @rustbot @y21 @bors