Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infinite_loop: continuing an outer loop leaves the inner loop #13512

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Oct 6, 2024

changelog: [infinite_loop]: detect a continue targeting an outer loop

Fix #13511

@rustbot
Copy link
Collaborator

rustbot commented Oct 6, 2024

r? @xFrednet

rustbot has assigned @xFrednet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 6, 2024
@samueltardieu samueltardieu force-pushed the issue-13511 branch 3 times, most recently from ec696e5 to 714c2fa Compare October 6, 2024 16:58
@samueltardieu samueltardieu marked this pull request as draft October 6, 2024 17:00
@samueltardieu samueltardieu marked this pull request as ready for review October 6, 2024 17:24
@xFrednet
Copy link
Member

xFrednet commented Oct 8, 2024

Looks good to me, nice and clean update! Thanks :D


'roses loop { let red = true;
'violets loop { let blue = true;
continue 'roses;}
/* and */ break /* now */}

It's fascinating what messages bors accepts for approval. Anyhow, not even sure if this is valid rust, but it should be :D

@bors
Copy link
Collaborator

bors commented Oct 8, 2024

📌 Commit 99ce411 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 8, 2024

⌛ Testing commit 99ce411 with merge d9c8d97...

@bors
Copy link
Collaborator

bors commented Oct 8, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing d9c8d97 to master...

@bors bors merged commit d9c8d97 into rust-lang:master Oct 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect infinite loop detection when using breakpoint labels and continue
4 participants