add new lint else_if_without_else #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
compiletest-rs failed to build (Manishearth/compiletest-rs#93) |
oli-obk
suggested changes
Jan 12, 2018
| /// **What it does:** Checks for usage of if expressions with an else if branch, | ||
| /// but without a final `else` branch. | ||
| /// | ||
| /// **Why is this bad?** Some coding guidelines require this. |
There was a problem hiding this comment.
Can you reference the MISRA standard rule here?
| /// } else if x.is_negative() { | ||
| /// b() | ||
| /// } else { | ||
| /// // we don't care about zero |
There was a problem hiding this comment.
zero is positive I think :D
just throw an unreachable!() here
There was a problem hiding this comment.
Actually, {integer}.is_positive() returns false for 0, which is what I had in mind.
| /// // we don't care about zero | ||
| /// } | ||
| /// ``` | ||
| declare_lint! { |
There was a problem hiding this comment.
Please make it a restriction lint. I don't think this should be part of the pedantic group
goodmanjonathan
force-pushed
the
else_if_without_else
branch
4 times, most recently
from
91e82ea to
f6f370e
Compare
goodmanjonathan
force-pushed
the
else_if_without_else
branch
from
f6f370e to
40c6f43
Compare
|
Addressed comments (except for x.is_positive(), as noted earlier). |
|
retriggering travis |
|
retriggering travis |
oli-obk
approved these changes
Jan 16, 2018
|
Thanks! |
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lint checks that every
ifexpression containing anelse ifhas a terminatingelseblock.Ifexpressions withoutelse ifs and/orelses are not linted.cc #2227