-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed build for latest rust master #2713
Conversation
Retriggering travis |
@alexreg: Looks like a few tests fail. |
PR rust-lang/rust#49724 broke our range inclusive things. I'm fixing them atm |
Clippy goes into an infinite loop on some input. I probably won't get to a machine where I can run gdb for the next few days :/ |
Tried to run the tests locally, but getting failures like this for clippy:
|
I don't see hangs on the Linux but inline and docs checks are messed up: Click me
|
@@ -45,7 +45,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass { | |||
|
|||
fn check_attrs(cx: &LateContext, name: &Name, attrs: &[Attribute]) { | |||
for attr in attrs { | |||
if attr.name().map_or(true, |n| n != "inline") { | |||
if attr.name() == "inline" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change ==
to !=
.
With that change all tests passed on my Linux box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, superb. Let's see what travis says
Whooo. Thanks everyone for the issue search and/or commits! I'll publish a new version later today |
Thanks for spotting that! Sorry about the sloppy edit. |
Fixes #2708.