Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding to restriction a lint that check for multiple inherent implementations #2816

Merged
merged 3 commits into from
May 31, 2018
Merged

adding to restriction a lint that check for multiple inherent implementations #2816

merged 3 commits into from
May 31, 2018

Conversation

mockersf
Copy link
Contributor

for #414

warn on each subsequent implementation of a struct, with a note showing the first implementation

/// ```
declare_clippy_lint! {
pub MULTIPLE_INHERENT_IMPL,
pedantic,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have this in the restriction group. It's something that you don't generally want in my book, but can be very helpful for satisfying standards or company policy

@mockersf mockersf changed the title adding to pedantic a lint that check for multiple inherent implementations adding to restriction a lint that check for multiple inherent implementations May 29, 2018
@mockersf
Copy link
Contributor Author

oh well latest nightly is not happy with clippy 😢
FF #![feature(macro_at_most_once_rep)] is needed as macros declare_lint and lint_array were changed
then there are a lot of errors like no field 'name' on type '&rustc::hir::Field' because of another change

@mati865
Copy link
Contributor

mati865 commented May 29, 2018

Nightly breakage is handled in #2817

@phansch
Copy link
Member

phansch commented May 29, 2018

retriggering travis

@phansch phansch closed this May 29, 2018
@phansch phansch reopened this May 29, 2018
@mati865
Copy link
Contributor

mati865 commented May 29, 2018

@phansch It needs to be rebased on top of master branch to make Travis pass.

@Manishearth
Copy link
Member

looks like you cherry picked the rustup? Please rebase over master instead 😄

@mockersf
Copy link
Contributor Author

my bad, my git-fu is not that good

@mockersf
Copy link
Contributor Author

one of the integration build failed with

error: component download failed for rust-docs-x86_64-unknown-linux-gnu
info: caused by: could not download file from 'https://static.rust-lang.org/dist/2018-05-29/rust-docs-nightly-x86_64-unknown-linux-gnu.tar.xz' to '/home/travis/.rustup/downloads/dafb4b05358273e2b1ce3e290a5d3a3a5ddde75ec3cb9431c028c3e1e4f7cea4.partial'
info: caused by: http request returned an unsuccessful status code: 503

@oli-obk oli-obk merged commit 1ba6587 into rust-lang:master May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants