Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on map_clone lint #2864

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Fix panic on map_clone lint #2864

merged 1 commit into from
Jun 21, 2018

Conversation

flip1995
Copy link
Member

Fixes #2862

Thanks @mati865 for providing an example, it was a quick fix from there!

@mati865
Copy link
Contributor

mati865 commented Jun 21, 2018

I think we cannot use BoolExt code from distinst, they have LGPL-3 license.
@mmstick?

@flip1995
Copy link
Member Author

Whoops sorry! Thanks for the observation! I just changed the test to a more minimal example. I don't know much about licensing, I hope that's ok now.

@oli-obk oli-obk merged commit 5f5fa08 into rust-lang:master Jun 21, 2018
@mmstick
Copy link

mmstick commented Jun 21, 2018

It's fine to use it. I'm the author of that code, and there's nothing really special about it.

@flip1995 flip1995 deleted the issue-2862 branch June 21, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic at map_clone.rs:39
4 participants