Always build CI on master #2940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that clippy now breaks nightlies, there is no other way to CI PRs that unbreak nightly. |
|
I tried this before and failed: #2551 |
|
Oh, perfect. |
|
Going to see if stuff is fixed now |
Manishearth
force-pushed
the
travis-toolchain
branch
from
ad14e22 to
eaf6270
Compare
|
ups I just fixed the prs branch xD |
oli-obk
force-pushed
the
travis-toolchain
branch
from
eaf6270 to
f226101
Compare
Manishearth
force-pushed
the
travis-toolchain
branch
from
f226101 to
44debe9
Compare
|
Ok, rebased and fixed travis |
|
er, pick one pull request and we'll stick with it, we're overwriting each others' commits here lol |
|
lol sorry |
|
and we can drop the git fudgery, with my PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches travis over to always using master.
We can alternatively pin a hash and bump it every time something breaks, but this feels cleaner (albeit less cacheable on the travis side)
needs kennytm/rustup-toolchain-install-master#6 to be released to work
r? @oli-obk