compiletest: clean rmeta data (from "cargo check") before running compiletest #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
reviewed
Oct 29, 2018
tests/compile-test.rs
Outdated
| @@ -75,7 +75,10 @@ fn config(mode: &str, dir: PathBuf) -> compiletest::Config { | |||
| } | |||
|
|
|||
| fn run_mode(mode: &str, dir: PathBuf) { | |||
| compiletest::run_tests(&config(mode, dir)); | |||
| let cfg = config(mode,dir); | |||
matthiaskrgr
force-pushed
the
clear_rmeta
branch
from
e8dd7aa to
dc6f217
Compare
|
I think this also fixes #2139? |
matthiaskrgr
force-pushed
the
clear_rmeta
branch
from
dc6f217 to
be7656d
Compare
|
Yup, looks like it. |
|
Nice, that should make using RLS and Clippy together a much better experience 🎆 🎇 ✨ |
|
bors r+ |
bors
added a commit
that referenced
this pull request
May 19, 2019
Fix compile-test from forcing a rebuild. If the `compile-test` test was run, then running a cargo build command immediately after caused everything to be rebuilt. This is because the `compile-test` test was deleting all `.rmeta` files in the target directory. Cargo recently switched to always generating `.rmeta` files (rust-lang/cargo#6883), and when the files are deleted, it thinks it needs to be rebuilt. I am not very familiar with compiletest or clippy, so please take a close look and test this out (with the most recent nightly). In particular, make sure it doesn't revert the fixes from #3380 (it seems to work for me). Also @oli-obk mentioned something related in rust-lang/rust#60190 (comment), and I want to make sure that is addressed as well. Fixes #4114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2896
Fixes #2139