Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI test cleanup: Extract expect_fun_call tests #3397

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

phansch
Copy link
Member

@phansch phansch commented Nov 2, 2018

Note that the new stderr file does not include a shadow-unrelated
error, because the new UI test file does not use #![warn(clippy::all)]

cc #2038

Note that the new stderr file does not include a `shadow-unrelated`
error, because the new UI test file does not use `#![warn(clippy::all)]`
@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 2, 2018
@matthiaskrgr
Copy link
Member

lgtm, thanks.
bors r+

bors bot added a commit that referenced this pull request Nov 2, 2018
3397: UI test cleanup: Extract expect_fun_call tests r=matthiaskrgr a=phansch

Note that the new stderr file does not include a `shadow-unrelated`
error, because the new UI test file does not use `#![warn(clippy::all)]`

cc #2038 

3398: UI test cleanup: Extract match_overlapping_arm tests r=matthiaskrgr a=phansch

cc #2038

Co-authored-by: Philipp Hansch <dev@phansch.net>
@bors
Copy link
Contributor

bors bot commented Nov 2, 2018

@bors bors bot merged commit 26569f3 into rust-lang:master Nov 2, 2018
@phansch phansch deleted the some_ui_test_cleanup4 branch November 2, 2018 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants