Mark writes to constants as side-effect-less #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KamilaBorowska
force-pushed
the
mark-writes-to-constant-as-sideeffectless
branch
from
5d66f83
to
7a0e132
Compare
KamilaBorowska
force-pushed
the
mark-writes-to-constant-as-sideeffectless
branch
from
7a0e132
to
847898f
Compare
oli-obk
reviewed
Dec 29, 2018
clippy_lints/src/no_effect.rs
Outdated
| ExprKind::Assign(ref left, ref right) => { | ||
| if has_no_effect(cx, left) { | ||
| let mut left = left; | ||
| while let ExprKind::Field(f, _) = &left.node { |
There was a problem hiding this comment.
We can unwrap a few other expressions, too. Index would be one i can think of. There may be others, too.
|
Okay, I added |
|
@bors r+ Thanks |
|
📌 Commit 9fe8a3e has been approved by |
bors
added a commit
that referenced
this pull request
Dec 29, 2018
… r=oli-obk Mark writes to constants as side-effect-less This is my first real contribution, so I probably did it wrong.
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Jan 4, 2019
Move constant write checks to temporary_assignment lint They make more sense here cc #3595
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first real contribution, so I probably did it wrong.