Add a test for #2526 #3811
Merged
Add a test for #2526 #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! @bors r+ |
|
📌 Commit a05f305 has been approved by |
mcarton
force-pushed
the
test-for-2526
branch
from
a05f305
to
3a9426e
Compare
|
I'm an idiot, I was fiddling with the attribute, to check for other crate type and forgot to restore it before committing 😅 |
|
Oh I also completely missed that! Thanks for the fast fix. Now this should be good to go. @bors r+ |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
📌 Commit 3a9426e has been approved by |
|
💔 Test failed - checks-travis |
mcarton
force-pushed
the
test-for-2526
branch
from
3a9426e
to
8bcd546
Compare
|
@bors r+ |
|
📌 Commit 8bcd546 has been approved by |
|
The test had an extra blank line… |
|
☀️ Test successful - checks-travis, status-appveyor |
|
Yea, you can r+ your own PRs. The convention is to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2526, which seems to have been fixed at some point, but I couldn't find a test for it.