Remove wrong lifetime from LintContext #4196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
reviewed
Jun 12, 2019
| @@ -92,7 +92,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UselessFormat { | |||
| } | |||
| } | |||
|
|
|||
| fn span_useless_format<'a, 'tcx: 'a, T: LintContext<'tcx>>(cx: &'a T, span: Span, help: &str, mut sugg: String) { | |||
| fn span_useless_format<T: LintContext>(cx: &T, span: Span, help: &str, mut sugg: String) { | |||
There was a problem hiding this comment.
cc @oli-obk T should be named C IMO, or maybe cx: &impl LintContext can be used (and, well, LintContext should probably be just LintCx).
eddyb
approved these changes
Jun 12, 2019
|
@bors r+ |
|
📌 Commit da3dd36 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 12, 2019
Remove wrong lifetime from LintContext Rustup rust-lang/rust#61735 changelog: none
|
💔 Test failed - checks-travis |
|
@bors retry (No output has been received in the last 10m0s) |
bors
added a commit
that referenced
this pull request
Jun 12, 2019
Remove wrong lifetime from LintContext Rustup rust-lang/rust#61735 changelog: none
|
💔 Test failed - status-appveyor |
|
Looks like a new breakage introduced by rustc? |
|
@phansch Yeah I'd recommend rustup-ing to just before rust-lang/rust#61735 and then apply the changes here, although I'm surprised clippy didn't appear as broken before rust-lang/rust#61735 was merged. |
|
Closed in favor of #4198 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rustup rust-lang/rust#61735
changelog: none