Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breakage due to rust-lang/rust#61856 #4306

Merged
merged 1 commit into from Jul 30, 2019
Merged

Fix breakage due to rust-lang/rust#61856 #4306

merged 1 commit into from Jul 30, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 30, 2019

changelog: none

@ghost
Copy link
Author

ghost commented Jul 30, 2019

It looks like rust-lang/rust#61856 broke Map::is_argument(..). Part of this fix should be reverted when that gets fixed. Also, I expected the dogfood test to warn for single_match_else in the is_argument function. Maybe it's a false negative or we're not checking for pedantic lints.

@flip1995
Copy link
Member

We check for pedantic lints in dogfood, and this should trigger the lint, weird...

.args(&["-D", "clippy::pedantic"])

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jul 30, 2019

📌 Commit 2f5c1d0 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jul 30, 2019

⌛ Testing commit 2f5c1d0 with merge b004461...

bors added a commit that referenced this pull request Jul 30, 2019
@bors
Copy link
Contributor

bors commented Jul 30, 2019

💔 Test failed - checks-travis

@flip1995
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Jul 30, 2019

⌛ Testing commit 2f5c1d0 with merge c9c547e...

bors added a commit that referenced this pull request Jul 30, 2019
@bors
Copy link
Contributor

bors commented Jul 30, 2019

💔 Test failed - checks-travis

@flip1995
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Jul 30, 2019

⌛ Testing commit 2f5c1d0 with merge e7d153a...

bors added a commit that referenced this pull request Jul 30, 2019
@bors
Copy link
Contributor

bors commented Jul 30, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing e7d153a to master...

@bors bors merged commit 2f5c1d0 into rust-lang:master Jul 30, 2019
@ghost ghost deleted the fix-breakage-20190730 branch July 31, 2019 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants