Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework suggestion generation of unit_arg lint #4455

Merged
merged 9 commits into from
May 31, 2020
Merged

Rework suggestion generation of unit_arg lint #4455

merged 9 commits into from
May 31, 2020

Commits on May 31, 2020

  1. Rework suggestion generation of unit_arg lint

    @flip1995
    flip1995 committed May 31, 2020
    Configuration menu
    Copy the full SHA
    0ab823c View commit details
    Browse the repository at this point in the history

  2. Adapt stderr and fixed files

    @flip1995
    flip1995 committed May 31, 2020
    Configuration menu
    Copy the full SHA
    380d941 View commit details
    Browse the repository at this point in the history

  3. Use multiple span_suggestions instead of multipart_suggestion 

    multipart suggestions aren't autofixable by rustfix yet
    @flip1995
    flip1995 committed May 31, 2020
    Configuration menu
    Copy the full SHA
    a1a1a4b View commit details
    Browse the repository at this point in the history

  4. Rework suggestion generation and use multipart_suggestion again

    @flip1995
    flip1995 committed May 31, 2020
    Configuration menu
    Copy the full SHA
    0f69caf View commit details
    Browse the repository at this point in the history

  5. Suggest to remove the semicolon of the last stmt in a block

    @flip1995
    flip1995 committed May 31, 2020
    Configuration menu
    Copy the full SHA
    f9c325f View commit details
    Browse the repository at this point in the history

  6. Move linting out in its own function

    @flip1995
    flip1995 committed May 31, 2020
    Configuration menu
    Copy the full SHA
    4c9cefa View commit details
    Browse the repository at this point in the history

  7. Update test files

    @flip1995
    flip1995 committed May 31, 2020
    Configuration menu
    Copy the full SHA
    6d15a14 View commit details
    Browse the repository at this point in the history

  8. Don't suggest to move empty blocks

    @flip1995
    flip1995 committed May 31, 2020
    Configuration menu
    Copy the full SHA
    a9cde3a View commit details
    Browse the repository at this point in the history

  9. Add tests for empty blocks

    @flip1995
    flip1995 committed May 31, 2020
    Configuration menu
    Copy the full SHA
    77dd0ea View commit details
    Browse the repository at this point in the history