Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra_unused_lifetimes false positive #4477

Merged
merged 3 commits into from Sep 2, 2019
Merged

Fix extra_unused_lifetimes false positive #4477

merged 3 commits into from Sep 2, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 31, 2019

Fixes #4291

changelog: Fix extra_unused_lifetimes false positive

@ghost ghost changed the title Fix extra_unused_lifetimes false positive WIP: Fix extra_unused_lifetimes false positive Aug 31, 2019
@ghost
Copy link
Author

ghost commented Aug 31, 2019

I just realized that this introduces false negatives for needless_lifetimes. I'll fix it tomorrow.

@ghost ghost changed the title WIP: Fix extra_unused_lifetimes false positive Fix extra_unused_lifetimes false positive Sep 1, 2019
@flip1995
Copy link
Member

flip1995 commented Sep 2, 2019

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 2, 2019

📌 Commit 2fdfd60 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Sep 2, 2019

⌛ Testing commit 2fdfd60 with merge 6dcdd46...

bors added a commit that referenced this pull request Sep 2, 2019
Fix `extra_unused_lifetimes` false positive

Fixes #4291

changelog: Fix `extra_unused_lifetimes` false positive
@bors
Copy link
Collaborator

bors commented Sep 2, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 6dcdd46 to master...

@bors bors merged commit 2fdfd60 into rust-lang:master Sep 2, 2019
@ghost ghost deleted the fix-4291 branch September 3, 2019 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to resolve extra_unused_lifetimes?
2 participants