Changes cast-lossless to a pedantic lint #4539
Conversation
|
You need to update the category where the lint is declared using the |
flip1995
added
the
S-waiting-on-author
|
Great! Thanks Mike. I'll do that this evening and get the PR updated :). |
|
Updated and corrected tests. I think (?) that the build failures are from the needed change to the clippy-driver: rust-lang/rust#64440 |
|
going to retrigger the PR build |
|
Here's the PR and change that caused the new build failures: https://github.com/rust-lang/rust/pull/60584/files#diff-707a0eda6b2f1a0537abc3d23133748cL1151. I will get a new PR opened soon to fix that issue. |
|
PR opened for the breaking change: #4545. |
|
@bors r+ rollup |
|
📌 Commit 6f1f413 has been approved by |
…lip1995 Changes cast-lossless to a pedantic lint As discussed in rust-lang#4528, this moves the cast-lossless lint from `all` to `pedantic`. I couldn't tell from description alone if it should also be removed from the complexity category, so I left it as part of complexity for now. I didn't see any impact to the tests from this change, but I could be wrong (as this is my first PR). fixes rust-lang#4528 changelog: Moves cast-lossless from default to checking only as a `pedantic` lint.
…lip1995 Changes cast-lossless to a pedantic lint As discussed in rust-lang#4528, this moves the cast-lossless lint from `all` to `pedantic`. I couldn't tell from description alone if it should also be removed from the complexity category, so I left it as part of complexity for now. I didn't see any impact to the tests from this change, but I could be wrong (as this is my first PR). fixes rust-lang#4528 changelog: Moves cast-lossless from default to checking only as a `pedantic` lint.
Rollup of 4 pull requests Successful merges: - #4511 (New lint: mem_replace_with_uninit) - #4535 (New lint: Require `# Safety` section in pub unsafe fn docs) - #4539 (Changes cast-lossless to a pedantic lint) - #4544 (#4542 remove machine applicable suggestion) Failed merges: r? @ghost changelog: none
Changes cast-lossless to a pedantic lint As discussed in #4528, this moves the cast-lossless lint from `all` to `pedantic`. I couldn't tell from description alone if it should also be removed from the complexity category, so I left it as part of complexity for now. I didn't see any impact to the tests from this change, but I could be wrong (as this is my first PR). fixes #4528 changelog: Moves cast-lossless from default to checking only as a `pedantic` lint.
|
☀️ Test successful - checks-travis, status-appveyor |
As discussed in #4528, this moves the cast-lossless lint from
alltopedantic.I couldn't tell from description alone if it should also be removed from the complexity category, so I left it as part of complexity for now. I didn't see any impact to the tests from this change, but I could be wrong (as this is my first PR).
fixes #4528
changelog: Moves cast-lossless from default to checking only as a
pedanticlint.