Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive in multiple_inherent_impl #4593

Merged
merged 1 commit into from
Sep 29, 2019
Merged

Fix false positive in multiple_inherent_impl #4593

merged 1 commit into from
Sep 29, 2019

Conversation

james9909
Copy link
Contributor

changelog: Fix false positive in multiple_inherent_impl by ignoring impls derived from macros.

Closes #4578.

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 28, 2019
@llogiq
Copy link
Contributor

llogiq commented Sep 29, 2019

Looks good. Thank you for making clippy better! @bors r+

@bors
Copy link
Collaborator

bors commented Sep 29, 2019

📌 Commit 189eaa5 has been approved by llogiq

@bors
Copy link
Collaborator

bors commented Sep 29, 2019

⌛ Testing commit 189eaa5 with merge fe920eb...

bors added a commit that referenced this pull request Sep 29, 2019
Fix false positive in `multiple_inherent_impl`

changelog: Fix false positive in `multiple_inherent_impl` by ignoring impls derived from macros.

Closes #4578.
@bors
Copy link
Collaborator

bors commented Sep 29, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: llogiq
Pushing fe920eb to master...

@bors bors merged commit 189eaa5 into rust-lang:master Sep 29, 2019
@james9909 james9909 deleted the fix-multiple-inherent-impls branch September 29, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple inherent impls should consider implementations by macros
4 participants