Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow everyone to assign labels with rustbot #4595

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Allow everyone to assign labels with rustbot #4595

merged 1 commit into from
Oct 8, 2019

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Sep 28, 2019

Also allows people to claim issues even if they aren't part of the org

changelog: none

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 28, 2019
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 30, 2019

📌 Commit 79c4543 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Sep 30, 2019

⌛ Testing commit 79c4543 with merge d7fd041...

bors added a commit that referenced this pull request Sep 30, 2019
Allow everyone to assign labels with rustbot

Also allows people to claim issues even if they aren't part of the org

changelog: none
@bors
Copy link
Contributor

bors commented Sep 30, 2019

💔 Test failed - status-appveyor

@llogiq
Copy link
Contributor

llogiq commented Sep 30, 2019

Looks like some loop lint broke?

@tesuji
Copy link
Contributor

tesuji commented Oct 3, 2019

@bors retry ?

@bors
Copy link
Contributor

bors commented Oct 3, 2019

@lzutao: 🔑 Insufficient privileges: not in try users

@phansch
Copy link
Member

phansch commented Oct 3, 2019

@bors retry

@bors
Copy link
Contributor

bors commented Oct 3, 2019

⌛ Testing commit 79c4543 with merge d7ea4ee...

bors added a commit that referenced this pull request Oct 3, 2019
Allow everyone to assign labels with rustbot

Also allows people to claim issues even if they aren't part of the org

changelog: none
@bors
Copy link
Contributor

bors commented Oct 3, 2019

💔 Test failed - status-appveyor

@phansch
Copy link
Member

phansch commented Oct 3, 2019

@bors retry may have been spurious (error: no such subcommand: +nightly)

bors added a commit that referenced this pull request Oct 3, 2019
Allow everyone to assign labels with rustbot

Also allows people to claim issues even if they aren't part of the org

changelog: none
@bors
Copy link
Contributor

bors commented Oct 3, 2019

⌛ Testing commit 79c4543 with merge e788902...

@bors
Copy link
Contributor

bors commented Oct 3, 2019

💔 Test failed - status-appveyor

@phansch
Copy link
Member

phansch commented Oct 4, 2019

@bors retry

@phansch
Copy link
Member

phansch commented Oct 4, 2019

hey @bors are you still there?

@bors
Copy link
Contributor

bors commented Oct 4, 2019

🍰 Activated

@phansch
Copy link
Member

phansch commented Oct 4, 2019

@bors retry (or do I have to r=flip1995?)

@phansch
Copy link
Member

phansch commented Oct 4, 2019

@bors r=flip1995

@bors
Copy link
Contributor

bors commented Oct 4, 2019

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Oct 4, 2019

📌 Commit 79c4543 has been approved by flip1995

@mati865
Copy link
Contributor

mati865 commented Oct 4, 2019

It has to wait on #4628

Looking at https://buildbot2.rust-lang.org/homu/queue/clippy bors is stuck on #4627

@phansch
Copy link
Member

phansch commented Oct 4, 2019

Oh thanks, I was just expecting the approved message, but I guess that is only posted when it's first approved

bors added a commit that referenced this pull request Oct 8, 2019
Allow everyone to assign labels with rustbot

Also allows people to claim issues even if they aren't part of the org

changelog: none
@bors
Copy link
Contributor

bors commented Oct 8, 2019

⌛ Testing commit 79c4543 with merge bbad77a...

@bors
Copy link
Contributor

bors commented Oct 8, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing bbad77a to master...

@bors bors merged commit 79c4543 into master Oct 8, 2019
@flip1995 flip1995 deleted the rustbot branch October 28, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants