Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some tests #4606

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Fix some tests #4606

merged 2 commits into from
Oct 2, 2019

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 1, 2019

Might be breaking the rustup? I can't tell, I can't reproduce errors on CI

changelog: none

rust-lang/rust#64963 (comment)

@Manishearth
Copy link
Member Author

@bors r=centril

@bors
Copy link
Contributor

bors commented Oct 1, 2019

📌 Commit f513aa3 has been approved by centril

@bors
Copy link
Contributor

bors commented Oct 1, 2019

⌛ Testing commit f513aa3 with merge 9a82250...

bors added a commit that referenced this pull request Oct 1, 2019
Fix some tests

Might be breaking the rustup? I can't tell, I can't reproduce errors on CI

rust-lang/rust#64963 (comment)
@Manishearth
Copy link
Member Author

Removed tests that only ICEd on rustc CI

@bors r=Centril

@bors
Copy link
Contributor

bors commented Oct 1, 2019

📌 Commit 4318854 has been approved by Centril

@bors
Copy link
Contributor

bors commented Oct 1, 2019

⌛ Testing commit 4318854 with merge 70b804b...

bors added a commit that referenced this pull request Oct 1, 2019
Fix some tests

Might be breaking the rustup? I can't tell, I can't reproduce errors on CI

rust-lang/rust#64963 (comment)
@Manishearth
Copy link
Member Author

#4607

@bors
Copy link
Contributor

bors commented Oct 1, 2019

💔 Test failed - checks-travis

@Manishearth
Copy link
Member Author

@bors r=centril retry

@bors
Copy link
Contributor

bors commented Oct 2, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Oct 2, 2019

📌 Commit 4318854 has been approved by centril

bors added a commit that referenced this pull request Oct 2, 2019
Fix some tests

Might be breaking the rustup? I can't tell, I can't reproduce errors on CI

changelog: none

rust-lang/rust#64963 (comment)
@bors
Copy link
Contributor

bors commented Oct 2, 2019

⌛ Testing commit 4318854 with merge dc340fe...

@bors
Copy link
Contributor

bors commented Oct 2, 2019

💔 Test failed - checks-travis

@Manishearth Manishearth merged commit 648e5b9 into rust-lang:master Oct 2, 2019
@Manishearth
Copy link
Member Author

Right, Rust is ICEing on our integration tests for non-us reasons. We can disable those two if we really want.

@Manishearth Manishearth deleted the rustup branch October 2, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants