Fix suggestion of explicit_counter_loop
#4691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed that the suggestion is kinda wrong; we suggest replacing just the argument of the |
|
Okay it looks like the only thing that retains the span of the entire original {
let result = match ::std::iter::IntoIterator::into_iter(<head>) {
mut iter => {
[opt_ident]: loop { // <------------- this expr
let mut __next;
match ::std::iter::Iterator::next(&mut iter) {
::std::option::Option::Some(val) => __next = val,
::std::option::Option::None => break
};
let <pat> = __next;
StmtKind::Expr(<body>);
}
}
};
result
} |
HMPerson1
changed the title
iter if needed in explicit_counter_loopexplicit_counter_loop
ghost
reviewed
Oct 18, 2019
flip1995
added
the
S-waiting-on-review
|
@bors r+ thanks! |
|
📌 Commit a9cb2b9 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 23, 2019
Fix suggestion of `explicit_counter_loop`
changelog: In the suggestion of `explicit_counter_loop`, if the `for` loop argument doesn't implement `Iterator`, then we suggest `x.into_iter().enumerate()` (or `x.iter{_mut}()` as appropriate). Also, the span of the suggestion has been corrected.
Fixes #4678
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: In the suggestion of
explicit_counter_loop, if theforloop argument doesn't implementIterator, then we suggestx.into_iter().enumerate()(orx.iter{_mut}()as appropriate). Also, the span of the suggestion has been corrected.Fixes #4678