Fix false positive in explicit_counter_loop lint #4803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the counter was used in a closure after the loop the lint didn't detect the usage of the counter correctly.
|
@bors r+ thanks! |
|
📌 Commit c88afce has been approved by |
bors
added a commit
that referenced
this pull request
Nov 11, 2019
Fix false positive in explicit_counter_loop lint When the counter was used in a closure after the loop the lint didn't detect the usage of the counter correctly. Fixes #4732
|
💔 Test failed - status-appveyor |
|
@bors retry (added the changelog to the PR body) |
bors
added a commit
that referenced
this pull request
Nov 11, 2019
Fix false positive in explicit_counter_loop lint When the counter was used in a closure after the loop the lint didn't detect the usage of the counter correctly. Fix false positive in `explicit_counter_loop` Fixes #4732
|
💔 Test failed - status-appveyor |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Nov 11, 2019
Fix false positive in explicit_counter_loop lint When the counter was used in a closure after the loop the lint didn't detect the usage of the counter correctly. Fix false positive in `explicit_counter_loop` Fixes #4732
|
💔 Test failed - checks-travis |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Nov 11, 2019
Fix false positive in explicit_counter_loop lint When the counter was used in a closure after the loop the lint didn't detect the usage of the counter correctly. changelog: Fix false positive in `explicit_counter_loop` Fixes #4732
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the counter was used in a closure after the loop the lint didn't detect the
usage of the counter correctly.
changelog: Fix false positive in
explicit_counter_loopFixes #4732