Normalize lint messages #5000
Merged
Normalize lint messages #5000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
reviewed
Jan 6, 2020
|
Thanks! @bors r+ |
|
📌 Commit c20642e has been approved by |
bors
added a commit
that referenced
this pull request
Jan 6, 2020
Normalize lint messages On rustc diagnostics, we prefer to use backticks over `'`, `"`, or something else. I think we should follow their manner here. In first commit, normalizes lint messages with backticks. In second commit, updates all stderrs. In third commit, updates descriptions on lintlist. changelog: none
|
💔 Test failed - checks-travis |
flip1995
added
the
S-waiting-on-bors
JohnTitor
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #5011) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Okay, rebased. |
|
@bors r=flip1995 |
|
📌 Commit f7a93f0 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 7, 2020
Normalize lint messages On rustc diagnostics, we prefer to use backticks over `'`, `"`, or something else. I think we should follow their manner here. In first commit, normalizes lint messages with backticks. In second commit, updates all stderrs. In third commit, updates descriptions on lintlist. changelog: none
|
💔 Test failed - checks-travis |
|
Uhm, I should have taken note of 32-bit target, fixed hopefully. |
|
@bors r+ |
|
📌 Commit abc49c3 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 7, 2020
Normalize lint messages On rustc diagnostics, we prefer to use backticks over `'`, `"`, or something else. I think we should follow their manner here. In first commit, normalizes lint messages with backticks. In second commit, updates all stderrs. In third commit, updates descriptions on lintlist. changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
bors
added a commit
that referenced
this pull request
Jan 8, 2020
Normalize lint messages in cast_precision_loss Follow-up of #5000 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On rustc diagnostics, we prefer to use backticks over
',", or something else. I think we should follow their manner here.In first commit, normalizes lint messages with backticks.
In second commit, updates all stderrs.
In third commit, updates descriptions on lintlist.
changelog: none