Split up transmute ui test

[JohnTitor]

Part of #2038

changelog: none

[flip1995]

Is it now possible to add run-rustfix to the new test files?

[flip1995]

$ wc -l tests/ui/*.stderr | sort -nr | head -n 7
 20404 total
   245 tests/ui/needless_range_loop.stderr
   245 tests/ui/match_same_arms.stderr
   235 tests/ui/non_copy_const.stderr
   234 tests/ui/matches.stderr
   220 tests/ui/drop_forget_ref.stderr
   213 tests/ui/indexing_slicing.stderr
   184 tests/ui/doc.stderr

Only 7 stderr files have more than 200 lines (hard limit target) now.

You can also reduce the limit to 245 now:

rust-clippy/clippy_dev/src/stderr_length_check.rs

Line 10 in f7b3e4f

const LIMIT: usize = 275;

[JohnTitor]

Is it now possible to add run-rustfix to the new test files?

We can't do at this point because applicability is unspecified in transmute_ptr_to_ptr/transmute_ptr_to_ref. But maybe we can do it as follow-up work.

You can also reduce the limit to 245 now

I think the 200 line limit is in the near future. But if it is appropriate to reduce the limit little by little, I'll do so.

[flip1995]

We can't do at this point because applicability is unspecified

Ah I remember now. Back when I added Applicability to every lint, I was to lazy to read all the transmute code to figure out the applicability of these lints 😄

So I guess follow up it is 👍

But if it is appropriate to reduce the limit little by little, I'll do so.

I think we should do this, so that we won't get new bigger test files again. Also @phansch did this now and then in some of these kind of PRs.

[JohnTitor]

I think we should do this, so that we won't get new bigger test files again.

It's reasonable. Decreased the line length limit.

[phansch]

@bors r+ thanks!

[bors]

📌 Commit c9d5cb9 has been approved by phansch

[bors]

⌛ Testing commit c9d5cb9 with merge f78cc07...

[bors]

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing f78cc07 to master...