Add option-env-unwrap lint
#5148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesuji
reviewed
Feb 9, 2020
flip1995
added
the
S-waiting-on-author
|
Thanks! @bors r+ |
|
📌 Commit a3a1587 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 9, 2020
…, r=flip1995 Add `option-env-unwrap` lint changelog: Add `option-env-unwrap` lint Fixes #5147
|
💔 Test failed - status-appveyor |
The tests were failing on windows because the `HOME` env variable doesn't exist on it so using the `PATH` variable to test instead.
krishna-veerareddy
force-pushed
the
issue-5147-option-env-unwrap
branch
from
7811ae0
to
b48b221
Compare
|
@bors r+ |
|
📌 Commit b48b221 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 10, 2020
…, r=flip1995 Add `option-env-unwrap` lint changelog: Add `option-env-unwrap` lint Fixes #5147
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Add
option-env-unwraplintFixes #5147