Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useless Rc<Rc<T>>, Rc<Box<T>>, Rc<&T>, Box<&T> #5349

Merged
merged 1 commit into from
Apr 2, 2020
Merged

useless Rc<Rc<T>>, Rc<Box<T>>, Rc<&T>, Box<&T> #5349

merged 1 commit into from
Apr 2, 2020

Conversation

jpospychala
Copy link
Contributor

@jpospychala jpospychala commented Mar 21, 2020 •
edited
Loading

refers to #2394

changelog: Add lints for Rc<Rc> and Rc<Box> and Rc<&T>, Box<&T>

this is based on top of another change #5310 so probably should go after that one.

@jpospychala jpospychala changed the title *WIP* *WIP* Add lints for Rc<Rc> and Rc<Box> Mar 21, 2020
@jpospychala jpospychala force-pushed the useless_rc branch 3 times, most recently from a8d691a to bfa0ff8 Compare March 21, 2020 21:13
@bors
Copy link
Collaborator

bors commented Mar 23, 2020

☔ The latest upstream changes (presumably #5319) made this pull request unmergeable. Please resolve the merge conflicts.

@jpospychala jpospychala force-pushed the useless_rc branch 2 times, most recently from 81a9113 to 063de76 Compare March 24, 2020 21:39
@jpospychala jpospychala changed the title *WIP* Add lints for Rc<Rc> and Rc<Box> [WIP] useless Rc<Rc<T>>, Rc<Box<T>>, Rc<&T> Mar 24, 2020
@jpospychala jpospychala force-pushed the useless_rc branch 3 times, most recently from 6ffa397 to 0d9804c Compare March 25, 2020 19:29
@jpospychala jpospychala changed the title [WIP] useless Rc<Rc<T>>, Rc<Box<T>>, Rc<&T> useless Rc<Rc<T>>, Rc<Box<T>>, Rc<&T> Mar 25, 2020
@bors
Copy link
Collaborator

bors commented Mar 30, 2020

☔ The latest upstream changes (presumably #5380) made this pull request unmergeable. Please resolve the merge conflicts.

Manishearth
Manishearth reviewed Mar 30, 2020
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good so far

CHANGELOG.md Outdated Show resolved Hide resolved
clippy_lints/src/types.rs Outdated Show resolved Hide resolved
@Manishearth
Copy link
Member

Manishearth commented Mar 30, 2020 •
edited
Loading

We discussed this a bit: we should make this a single lint

@bors
Copy link
Collaborator

bors commented Mar 30, 2020

☔ The latest upstream changes (presumably #5294) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth
Copy link
Member

Should we just close the other PR and land these all together?

(Also this needs a rebase)

@flip1995 flip1995 added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Mar 31, 2020
@jpospychala jpospychala mentioned this pull request Apr 1, 2020
Closed
@jpospychala jpospychala changed the title useless Rc<Rc<T>>, Rc<Box<T>>, Rc<&T> useless Rc<Rc<T>>, Rc<Box<T>>, Rc<&T>, Box<&T> Apr 1, 2020
@jpospychala jpospychala force-pushed the useless_rc branch 3 times, most recently from 0dcf54a to b02335a Compare April 1, 2020 20:48
@bors
Copy link
Collaborator

bors commented Apr 1, 2020

☔ The latest upstream changes (presumably #5401) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth
Copy link
Member

@bors r+

thanks!

@bors
Copy link
Collaborator

bors commented Apr 2, 2020

📌 Commit f8e892d has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Apr 2, 2020

⌛ Testing commit f8e892d with merge a840d59...

@bors
Copy link
Collaborator

bors commented Apr 2, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing a840d59 to master...

@bors bors merged commit a840d59 into rust-lang:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth left review comments

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpospychala @bors @Manishearth @flip1995