Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for string_lit_as_bytes issue #5672

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

phansch
Copy link
Member

@phansch phansch commented Jun 1, 2020

Closes #5619

Before the fix in rust-lang/rust#72637, string_lit_as_bytes was incorrectly triggering on the env! macro. With the fix merged, this test makes sure that the lint is not triggering anymore.

changelog: none

@rust-highfive
Copy link

r? @yaahc

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 1, 2020
@flip1995
Copy link
Member

flip1995 commented Jun 2, 2020

@bors r=yaahc

@bors
Copy link
Contributor

bors commented Jun 2, 2020

📌 Commit ae0ce22 has been approved by yaahc

@bors
Copy link
Contributor

bors commented Jun 2, 2020

⌛ Testing commit ae0ce22 with merge 153ef1c...

@bors
Copy link
Contributor

bors commented Jun 2, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: yaahc
Pushing 153ef1c to master...

@bors bors merged commit 153ef1c into rust-lang:master Jun 2, 2020
@phansch phansch deleted the regression-test-env branch July 5, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for 'string_lit_as_bytes' in conjunction with 'env!'
5 participants