Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a broken link in CONTRIBUTING.md #5781

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Fix a broken link in CONTRIBUTING.md #5781

merged 1 commit into from
Jul 9, 2020

Conversation

giraffate
Copy link
Contributor

changelog: none

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @phansch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 9, 2020
@phansch
Copy link
Member

phansch commented Jul 9, 2020

@bors r+ thanks!

@bors
Copy link
Collaborator

bors commented Jul 9, 2020

📌 Commit c79c688 has been approved by phansch

@bors
Copy link
Collaborator

bors commented Jul 9, 2020

⌛ Testing commit c79c688 with merge be88122...

@bors
Copy link
Collaborator

bors commented Jul 9, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing be88122 to master...

@bors bors merged commit be88122 into rust-lang:master Jul 9, 2020
@giraffate giraffate deleted the fix_a_broken_link branch July 9, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@phansch phansch

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giraffate @rust-highfive @phansch @bors