Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint .min(x).max(y) with x < y #5871

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Lint .min(x).max(y) with x < y #5871

merged 2 commits into from
Aug 10, 2020

Conversation

wiomoc
Copy link
Contributor

@wiomoc wiomoc commented Aug 6, 2020 •
edited by flip1995
Loading

Fixes #5854

changelog: Also lint ord.min(a).max(b), where a < b in [min_max] lint

@rust-highfive
Copy link

r? @flip1995

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 6, 2020
flip1995
flip1995 reviewed Aug 7, 2020
View reviewed changes
clippy_lints/src/minmax.rs Outdated Show resolved Hide resolved
@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 7, 2020
@flip1995
Copy link
Member

flip1995 commented Aug 7, 2020

Thanks, waiting for rustup.

@flip1995 flip1995 added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Aug 7, 2020
@flip1995
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 10, 2020

📌 Commit 87e7409 has been approved by flip1995

@flip1995 flip1995 mentioned this pull request Aug 10, 2020
Merged
bors added a commit that referenced this pull request Aug 10, 2020
@bors
Auto merge of #5883 - flip1995:rollup-x9mftxe, r=flip1995
c576bed 
Rollup of 5 pull requests

Successful merges:

 - #5825 (Add the new lint `same_item_push`)
 - #5869 (New lint against `Self` as an arbitrary self type)
 - #5870 (enable #[allow(clippy::unsafe_derive_deserialize)])
 - #5871 (Lint .min(x).max(y) with x < y)
 - #5874 (Make the docs clearer for new contributors)

Failed merges:

r? @ghost

changelog: rollup
@bors bors merged commit ee8db50 into rust-lang:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 left review comments

Assignees

@flip1995 flip1995

Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.min(x).max(y) with x < y
4 participants
@wiomoc @rust-highfive @flip1995 @bors