Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FP for redundant_closure_call #5920

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

giraffate
Copy link
Contributor

Fix #5916

changelog: Fix FP for redundant_closure_call when called in function body

@rust-highfive
Copy link

r? @phansch

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 18, 2020
Visit the nested things like function body when checking closure call.
@giraffate giraffate force-pushed the fix_fp_for_redundant_closure_call branch from e62c6d0 to b2c2266 Compare August 24, 2020 00:50
@ghost
Copy link

ghost commented Aug 25, 2020

LGTM.

Let's see if this works...
@bors r+

@bors
Copy link
Collaborator

bors commented Aug 25, 2020

📌 Commit 9fe0ac3 has been approved by mikerite

@bors
Copy link
Collaborator

bors commented Aug 25, 2020

⌛ Testing commit 9fe0ac3 with merge 64b53f3...

@bors
Copy link
Collaborator

bors commented Aug 25, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: mikerite
Pushing 64b53f3 to master...

@bors bors merged commit 64b53f3 into rust-lang:master Aug 25, 2020
@giraffate giraffate deleted the fix_fp_for_redundant_closure_call branch August 25, 2020 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for redundant_closure_call when called in a closure
4 participants