Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref style link false positive #6107

Merged
merged 1 commit into from
Oct 10, 2020

Conversation

nahuakang
Copy link
Contributor

@nahuakang nahuakang commented Oct 2, 2020

This PR does not fix #5834, but it records the problematic link text as a known problem inside doc_markdown lint.

r? @flip1995

  • Followed [lint naming conventions][lint_naming]
  • Added passing UI tests (including committed .stderr file)
  • cargo test passes locally
  • Executed cargo dev update_lints
  • Added lint documentation
  • Run cargo dev fmt

Please keep the line below
changelog: Document problematic link text style as known problem for doc_markdown

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthiaskrgr (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 2, 2020
@nahuakang nahuakang marked this pull request as draft October 2, 2020 19:15
@flip1995
Copy link
Member

flip1995 commented Oct 2, 2020

r? @flip1995

Thanks for the contribution and welcome to Clippy!

This is ready to get merged, after you squash the commits. See this blog post on how to do it: https://www.internalpointers.com/post/squash-commits-into-one-git

@nahuakang nahuakang marked this pull request as ready for review October 2, 2020 19:38
@nahuakang nahuakang force-pushed the ref_style_link_false_positive branch from 7bdb84f to f302af3 Compare October 2, 2020 20:07
@flip1995
Copy link
Member

Thanks! (Sorry for taking so long to approve. I hate that GitHub sometimes does not show notifications for force pushes... Not your fault though)

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 10, 2020

📌 Commit f302af3 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Oct 10, 2020

⌛ Testing commit f302af3 with merge 8b70b84...

@bors
Copy link
Collaborator

bors commented Oct 10, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8b70b84 to master...

@bors bors merged commit 8b70b84 into rust-lang:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive in doc_markdown lint: reference style link to type in external crate
5 participants