Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Constant::Binary back to refcount clone byte strings #6112

Closed
wants to merge 1 commit into from

Conversation

rschoon
Copy link
Contributor

@rschoon rschoon commented Oct 5, 2020

This changes the Constant type to be able to copy the shared reference to a byte string again.

This depends on rust-lang/rust#77560

changelog: none

@rust-highfive
Copy link

r? @phansch

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 5, 2020
@rschoon rschoon changed the title Change clippy's Constant back to refcount clone byte strings Change Constant::Binary back to refcount clone byte strings Oct 5, 2020
@ghost
Copy link

ghost commented Oct 5, 2020

Is this pull request needed? I think the change should get synced from rust after that pull request is merged.

@ebroto
Copy link
Member

ebroto commented Oct 5, 2020

@rschoon in case your PR to rust-lang/rust is accepted, the workflow is to sync back that commit to this repo like @mikerite suggests.

Take a look here for a description of the process. Anyone can do it, although the process is a bit cumbersome for now.

@ebroto ebroto closed this Oct 5, 2020
@rschoon
Copy link
Contributor Author

rschoon commented Oct 5, 2020

I'll take a look. When I tried getting git-subtree working before (following the instructions in the rustc dev guide) I couldn't get it to work, but I didn't have the patched version of git-subtree.

@ebroto
Copy link
Member

ebroto commented Oct 5, 2020

Thanks! In case of running into problems, don't hesitate to ping me or @flip1995, as we've done it before it would be easier for us because the first time it takes around 40 mins IIRC 😅

@rschoon rschoon deleted the fix-litkind-rc-bytebuf branch October 6, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants