-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not lint float fractions in mistyped_literal_suffixes
#6114
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors r+ thanks! |
📌 Commit 428ef36 has been approved by |
Do not lint float fractions in `mistyped_literal_suffixes` As suggested in #4706 (comment), the fractional part is now ignored (the integer part is checked instead). Fixes: #4706 changelog: `mistyped_literal_suffixes` no longer warns on the fractional part of a float (e.g. 713.23_64)
💔 Test failed - checks-action_test |
@bors retry (rustup) |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
As suggested in #4706 (comment), the fractional part is now ignored (the integer part is checked instead).
Fixes: #4706
changelog:
mistyped_literal_suffixes
no longer warns on the fractional part of a float (e.g. 713.23_64)