Check when `from_utf8` is called from sliced byte array from string #6134

patrickelectric · 2020-10-08T03:30:19Z

Please keep the line below
changelog: Fix #5487: Add linter to check when from_utf8 is called from sliced byte array from string.

rust-highfive · 2020-10-08T03:30:22Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @phansch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

bors · 2020-10-08T21:56:44Z

☔ The latest upstream changes (presumably #6117) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

patrickelectric · 2020-10-17T21:18:10Z

ping @phansch

patrickelectric · 2020-10-24T11:24:56Z

ping @phansch

clippy_lints/src/strings.rs

phansch · 2020-10-30T10:47:58Z

Hey @llogiq, would you mind taking over the review of this new lint? (I'm kind of doing an open source break for a bit with all the things going on right now and removed myself from the review rotation)

llogiq · 2020-10-30T19:53:21Z

Sure thing. I'll see if I can find the time to catch up over the weekend.

llogiq

This looks mostly good, I only left a few small nitpicky comments. Please let me know if you want to tackle the suggestion and if so, whether you need any help.

llogiq · 2020-10-31T07:42:17Z

clippy_lints/src/strings.rs

+            if method_names.len() == 1;
+            if method_names[0] == sym!(as_bytes);


I think this might be if &[sym!(as_bytes)] == method_names;.

This is not possible since method_names is a vector and the other side is a fixed size array &[something, 1], I may be wrong, but I was unable to find a way to accomplish such thing.
Any tips ?

Hmmmm...perhaps &method_names or even &method_names[..]? Sorry, I don't have the time to check.

If the intention is to use a slice pattern, it should be an if let

clippy_lints/src/strings.rs

patrickelectric · 2020-10-31T20:09:55Z

Is it possible to kindly add the hacktoberfest-accepted tag or accept ?
From the hacktoberfest page:

Pull requests in repositories with the ‘hacktoberfest’ topic will also need to be merged, approved by a maintainer, or labeled as ‘hacktoberfest-accepted’ in order to qualify. The deadline for completions, merging, labeling, and approving is November 1.

llogiq

Sure!

llogiq

Another thing i found that may improve the lint, but no blocker.

clippy_lints/src/strings.rs

llogiq · 2020-11-04T22:45:09Z

Hey, @patrickelectric I think we can merge this if you change the lint group to complexity, we can do the rest of the changes as a follow-up. What do you think?

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>

patrickelectric · 2020-11-05T00:21:26Z

Hi @llogiq thank you for your review and catch up, I believe that everything requested was done, let me know if otherwise.

llogiq · 2020-11-07T17:06:22Z

Thank you! @bors r+

bors · 2020-11-07T17:06:24Z

📌 Commit bc27d14 has been approved by llogiq

bors · 2020-11-07T17:06:32Z

⌛ Testing commit bc27d14 with merge 92ba075...

bors · 2020-11-07T17:26:56Z

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 92ba075 to master...

rust-highfive assigned phansch Oct 8, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 8, 2020

patrickelectric changed the title ~~Add string_from_utf8_as_bytes linter~~ Check when from_utf8 is called from sliced byte array from string Oct 8, 2020

patrickelectric force-pushed the as_utf8 branch 4 times, most recently from 4177a96 to 0336d71 Compare October 8, 2020 13:46

patrickelectric force-pushed the as_utf8 branch from 0336d71 to 7813ec2 Compare October 8, 2020 22:25

giraffate reviewed Oct 24, 2020

View reviewed changes

clippy_lints/src/strings.rs Outdated Show resolved Hide resolved

patrickelectric force-pushed the as_utf8 branch 2 times, most recently from d58c1e7 to 5da2b18 Compare October 24, 2020 19:22

llogiq requested changes Oct 31, 2020

View reviewed changes

patrickelectric force-pushed the as_utf8 branch 2 times, most recently from d5a104c to f2d32b3 Compare October 31, 2020 19:56

patrickelectric requested a review from llogiq October 31, 2020 20:07

llogiq approved these changes Nov 1, 2020

View reviewed changes

clippy_lints/src/strings.rs Outdated Show resolved Hide resolved

clippy_lints/src/strings.rs Outdated Show resolved Hide resolved

phansch assigned llogiq and unassigned phansch Nov 4, 2020

patrickelectric force-pushed the as_utf8 branch from f2d32b3 to e5fa0c1 Compare November 5, 2020 00:12

Add string_from_utf8_as_bytes linter

bc27d14

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>

patrickelectric force-pushed the as_utf8 branch from e5fa0c1 to bc27d14 Compare November 5, 2020 00:18

bors merged commit 92ba075 into rust-lang:master Nov 7, 2020

bors mentioned this pull request Nov 7, 2020

Add suspicious_operation_groupings lint #6086

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check when `from_utf8` is called from sliced byte array from string #6134

Check when `from_utf8` is called from sliced byte array from string #6134

patrickelectric commented Oct 8, 2020

rust-highfive commented Oct 8, 2020

bors commented Oct 8, 2020

patrickelectric commented Oct 17, 2020

patrickelectric commented Oct 24, 2020

phansch commented Oct 30, 2020

llogiq commented Oct 30, 2020

llogiq left a comment

llogiq Oct 31, 2020

patrickelectric Oct 31, 2020 •

edited

Loading

llogiq Nov 1, 2020

ebroto Nov 2, 2020

patrickelectric commented Oct 31, 2020

llogiq left a comment

llogiq left a comment

llogiq commented Nov 4, 2020

patrickelectric commented Nov 5, 2020

llogiq commented Nov 7, 2020

bors commented Nov 7, 2020

bors commented Nov 7, 2020

bors commented Nov 7, 2020

		if method_names.len() == 1;
		if method_names[0] == sym!(as_bytes);

Check when from_utf8 is called from sliced byte array from string #6134

Check when from_utf8 is called from sliced byte array from string #6134

Conversation

patrickelectric commented Oct 8, 2020

rust-highfive commented Oct 8, 2020

bors commented Oct 8, 2020

patrickelectric commented Oct 17, 2020

patrickelectric commented Oct 24, 2020

phansch commented Oct 30, 2020

llogiq commented Oct 30, 2020

llogiq left a comment

Choose a reason for hiding this comment

llogiq Oct 31, 2020

Choose a reason for hiding this comment

patrickelectric Oct 31, 2020 • edited Loading

Choose a reason for hiding this comment

llogiq Nov 1, 2020

Choose a reason for hiding this comment

ebroto Nov 2, 2020

Choose a reason for hiding this comment

patrickelectric commented Oct 31, 2020

llogiq left a comment

Choose a reason for hiding this comment

llogiq left a comment

Choose a reason for hiding this comment

llogiq commented Nov 4, 2020

patrickelectric commented Nov 5, 2020

llogiq commented Nov 7, 2020

bors commented Nov 7, 2020

bors commented Nov 7, 2020

bors commented Nov 7, 2020

Check when `from_utf8` is called from sliced byte array from string #6134

Check when `from_utf8` is called from sliced byte array from string #6134

patrickelectric Oct 31, 2020 •

edited

Loading