Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ci on master branch; run the --fix test in the correct directory #6504

Merged
merged 1 commit into from
Dec 24, 2020
Merged

fix ci on master branch; run the --fix test in the correct directory #6504

merged 1 commit into from
Dec 24, 2020

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Dec 24, 2020 •
edited
Loading

Turned out the --fix test was run in the wrong directory.

Please write a short comment explaining your change (or "none" for internal only changes)
changelog: none

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 24, 2020
@matthiaskrgr
Copy link
Member Author

This should fix ci failures that only appear on the master branch for some reason: https://github.com/rust-lang/rust-clippy/runs/1597967891

@bors try

bors added a commit that referenced this pull request Dec 24, 2020
@bors
Auto merge of #6504 - matthiaskrgr:cifix, r=<try>
f53445f 
fix ci on master branch; build clippy-driver before running cargo-clippy

*Please write a short comment explaining your change (or "none" for internal only changes)*
changelog:
@bors
Copy link
Collaborator

bors commented Dec 24, 2020

⌛ Trying commit ac9b371 with merge f53445f...

@bors
Copy link
Collaborator

bors commented Dec 24, 2020

☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Build commit: f53445f (f53445fda8bf2824aeb81c17dbb38cee2033cbeb)

@matthiaskrgr
Copy link
Member Author

debugging..
@bors try

bors added a commit that referenced this pull request Dec 24, 2020
@bors
Auto merge of #6504 - matthiaskrgr:cifix, r=<try>
d392af3 
fix ci on master branch; build clippy-driver before running cargo-clippy

*Please write a short comment explaining your change (or "none" for internal only changes)*
changelog: none
@bors
Copy link
Collaborator

bors commented Dec 24, 2020

⌛ Trying commit 2ecb2dd with merge d392af3...

@bors
Copy link
Collaborator

bors commented Dec 24, 2020

☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Build commit: d392af3 (d392af326d7853df81e50a5cda6dbe272ed6eb0b)

@matthiaskrgr
Copy link
Member Author

Let's give this a final
@bors try

@bors
Copy link
Collaborator

bors commented Dec 24, 2020

⌛ Trying commit 2218dd6 with merge 7484c30...

bors added a commit that referenced this pull request Dec 24, 2020
@bors
Auto merge of #6504 - matthiaskrgr:cifix, r=<try>
7484c30 
fix ci on master branch; build clippy-driver before running cargo-clippy

Turned out the --fix test was run in the wrong directory.

*Please write a short comment explaining your change (or "none" for internal only changes)*
changelog: none
@matthiaskrgr matthiaskrgr changed the title fix ci on master branch; build clippy-driver before running cargo-clippy fix ci on master branch; run the --fix test in the correct directory Dec 24, 2020
@bors
Copy link
Collaborator

bors commented Dec 24, 2020

☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Build commit: 7484c30 (7484c30ffc775a87b6016e90cc346ddb1c600d50)

@matthiaskrgr
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 24, 2020

📌 Commit 2218dd6 has been approved by matthiaskrgr

@bors
Copy link
Collaborator

bors commented Dec 24, 2020

⌛ Testing commit 2218dd6 with merge 02399f4...

@bors
Copy link
Collaborator

bors commented Dec 24, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing 02399f4 to master...

@bors bors merged commit 02399f4 into rust-lang:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthiaskrgr @rust-highfive @bors @llogiq