Fix all occurences needless_borrow internally

[Jarcho]

The bug that got 'needless_borrow' moved into the nursery was fixed two years ago in d4370f8.

This did trigger over a thousand times internally, so that's all the other changes. I vetted most of them, but there's a lot The only interesting change is to the lint list. declare_tool_lint already makes a reference, so there's no need to take a reference to the lints.

changelog: None

[rust-highfive]

r? @phansch

(rust-highfive has picked a reviewer for you, use r? to override)

[phansch]

@Jarcho Did you happen to run lintcheck to see if there were any false positives or similar amounts of triggers?

I'm currently a bit hesitant to merge this because it caused so many changes in our codebase alone.

[bors]

☔ The latest upstream changes (presumably #6896) made this pull request unmergeable. Please resolve the merge conflicts.

[Jarcho]

Not bad overall

• rayon: 7
• regex: 1
• ripgrep: 2
• syn: 1
• tam-oidc: 3
• xsv: 3

Pretty much every instance in clippy is from taking a reference to a HIR node. Those are mostly all references to start with.

[bors]

☔ The latest upstream changes (presumably #6957) made this pull request unmergeable. Please resolve the merge conflicts.

[flip1995]

The changes LGTM and I would merge them like this after a rebase.

But I would do the actual move of the lint in another PR. That PR should then add tests for the remaining open issues about this lint to verify that they're fixed or to at least know the state this lint is in.

[flip1995]

This is a great code cleanup btw! Thanks for all the work you put into this!

[Jarcho]

I'll pull out the category change when I rebase it. There's still the bad suggestion with pattern references to deal with. The rest of those are just enhancements.

[bors]

☔ The latest upstream changes (presumably #7027) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #6463) made this pull request unmergeable. Please resolve the merge conflicts.

[flip1995]

@Jarcho Sorry that we missed your rebase. Please self-approve this after rebasing again.

@bors delegate+ p=10

[bors]

✌️ @Jarcho can now approve this pull request

[flip1995]

@bors r=phansch,flip1995

Thanks!

[bors]

📌 Commit 12fce55 has been approved by phansch,flip1995

[bors]

⌛ Testing commit 12fce55 with merge 6ae0835...

[Jarcho]

Looks like you got to it before me.

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch,flip1995
Pushing 6ae0835 to master...