Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for .to_string().into_bytes() in string_lit_to_bytes #6959

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Check for .to_string().into_bytes() in string_lit_to_bytes #6959

merged 1 commit into from
Mar 25, 2021

Conversation

ebobrow
Copy link
Contributor

@ebobrow ebobrow commented Mar 24, 2021 •
edited
Loading

fixes #6927

changelog: Add a check for into_bytes() to string_lit_to_bytes lint

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @camsteffen (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 24, 2021
camsteffen
camsteffen suggested changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@camsteffen camsteffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first contribution! Just a few comments.

clippy_lints/src/strings.rs Outdated Show resolved Hide resolved
clippy_lints/src/strings.rs Outdated Show resolved Hide resolved
clippy_lints/src/strings.rs Outdated Show resolved Hide resolved
clippy_lints/src/strings.rs Outdated Show resolved Hide resolved
clippy_lints/src/strings.rs Outdated Show resolved Hide resolved
@ebobrow
Copy link
Contributor Author

ebobrow commented Mar 24, 2021

Thanks for the review! I've applied your suggestions.

@ebobrow ebobrow requested a review from camsteffen March 24, 2021 21:18
camsteffen
camsteffen approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@camsteffen camsteffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please squash your commits.

@camsteffen
Copy link
Contributor

camsteffen commented Mar 25, 2021 •
edited
Loading

Thanks! @bors r+

@camsteffen
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 25, 2021

📌 Commit e9ebc27 has been approved by camsteffen

@bors
Copy link
Collaborator

bors commented Mar 25, 2021

⌛ Testing commit e9ebc27 with merge 981ffa7...

@bors
Copy link
Collaborator

bors commented Mar 25, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing 981ffa7 to master...

@bors bors merged commit 981ffa7 into rust-lang:master Mar 25, 2021
@ebobrow ebobrow deleted the iss-6927-fix branch March 25, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camsteffen camsteffen camsteffen approved these changes

Assignees

@camsteffen camsteffen

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

string_lit_as_bytes should also detect "str".to_string().into_bytes()
4 participants
@ebobrow @rust-highfive @camsteffen @bors